Some issues abourt LLVM JIT #585
HungMingWu
started this conversation in
General
Replies: 1 comment
-
Thanks for looking at this. The LLVM JIT code is highly experimential (and hasn't been built in a while, which is why you found it broken). Your changes seem fine to me, but at some point I need to look at the upgraded LLVM and see what changed. If you want to propose diffs to improve it that's fine, but again the design for codegen isn't stable or particularly well thought out right now. As far as std::function vs function_ref goes, the idea is to get better performance by avoiding the std::function overhead if possible. Hopefully newer compiler versions fix their bug and then we won't have to worry about the optimization setting. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi Mike, I met some issues about enable LLVM support.
it crash on here.
slang::runtime::setOutputHandler([&](string_view text) { result += text; });
From the comment
// Work around a clang optimization bug on deallocating "result" before lambda call [[clang::optnone]]
GCC have identical behavior, So I change it to
Now it works. (My gcc is 11.2)
Whether change from function_ref to function a good idea?
Beta Was this translation helpful? Give feedback.
All reactions