Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-225: Godot editor can not be closed #225

Closed
Krigu opened this issue Jul 12, 2023 · 4 comments
Closed

GD-225: Godot editor can not be closed #225

Krigu opened this issue Jul 12, 2023 · 4 comments
Assignees
Labels
godot related issue Its a bug by Godot engine and can't be fixed by GdUnit

Comments

@Krigu
Copy link

Krigu commented Jul 12, 2023

The used GdUnit4 version:

gdUnit4 4.1.2

The used Godot version:

Godot 4.1

OS including version:

Manjaro Linux

Describe the bug

We are using GdUnit in our build pipeline and after updating to Godot 4.1 the build does not finish, because after sucessfully executing the tests (in headless mode) the build gets stuck. We are running the tests with the following command:

./addons/gdUnit4/runtest.sh -a tests/gdunit/ -c

Steps to Reproduce

I was able to reproduce the error without the command line tools in a clean project.

  • Started godot via command line
  • Created a new project in Godot 4.1
  • Added gdUnit Plugin 4.1.2
  • Reloaded project
    => The terminal is showing "Unload GdUnit4 Plugin success", but then it hangs and the process does not get terminated.

Hope this helps to find the bugs. If you need more information please let me know. Thanks for gdUnit btw., we really appreciate it

@Krigu Krigu added the bug Something isn't working label Jul 12, 2023
@MikeSchulze
Copy link
Owner

MikeSchulze commented Jul 12, 2023

I current working on running GdUnit4 on Godot 4.1, but looks like Godot 4.1 itself has some issues.
#224

How you installed the plugin?
Have you try stop Godot and delete the .godot folder and restart Godot?

@MikeSchulze
Copy link
Owner

It is a Godot crash issue, the plugin is unloading successfully.
There a many issues about crashing for release 4.1

----------------------------------------------------------------
Cleanup singletons ["GdUnitCommandHandler", "GdUnitAsserts"]

	Unregister singleton 'GdUnitCommandHandler'
	Free singeleton instance 'GdUnitCommandHandler:<RefCounted#-9223369276700690972>'
	Succesfully freed 'GdUnitCommandHandler'

	Unregister singleton 'GdUnitAsserts'
	Free singeleton instance 'GdUnitAsserts:[]'
	Succesfully freed 'GdUnitAsserts'
----------------------------------------------------------------
Unload GdUnit4 Plugin success
EditorSettings: Save OK!

@MikeSchulze
Copy link
Owner

I tested around and removed class by class and finally ended up in a empty plugin, but it crashs too.
Finally i create a new project and build a new plugin over the Godot tools.
Godot crashes just by adding the print statement ..., i will open a Godot issue, and close this issue as Godot releated

@tool
extends EditorPlugin


func _enter_tree():
	# Initialization of the plugin goes here.
	pass


func _exit_tree():
	prints("_exit_tree")
	# Clean-up of the plugin goes here.
	pass

@MikeSchulze MikeSchulze added the godot related issue Its a bug by Godot engine and can't be fixed by GdUnit label Jul 12, 2023
@MikeSchulze MikeSchulze changed the title Godot editor can not be closed GD-225: Godot editor can not be closed Jul 12, 2023
@MikeSchulze MikeSchulze removed the bug Something isn't working label Jul 13, 2023
@Krigu
Copy link
Author

Krigu commented Jul 17, 2023

Thank you for adressing it so quickly.

I fixed it temporarly by removing the line prints("Unload GdUnit4 Plugin success") in the file plugin.gd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
godot related issue Its a bug by Godot engine and can't be fixed by GdUnit
Projects
Status: Done
Development

No branches or pull requests

2 participants