Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate actual rendering is successful in ReactTestRenderer usage #119

Open
MikeTheCanuck opened this issue Dec 11, 2017 · 0 comments
Open

Comments

@MikeTheCanuck
Copy link
Owner

MikeTheCanuck commented Dec 11, 2017

In #118 I've implemented a test that is meant to fail if rendering fails (a basic smoke test that the Component is working at runtime).

However, it's entirely possible that with #118 I am merely outputting data without actually having React render the component (without crashing).

Look further into https://youtu.be/9WXxda3MNuk?t=10m25s as the inspiration for these added tests - verify whether this is performing an actual render() and if not, add the additional logic that the subsequent slide indicates.

@MikeTheCanuck MikeTheCanuck changed the title Validate actual rendering is successful Validate actual rendering is successful in ReactTestRenderer usage Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant