Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eslint generates multiple unmet peer dependencies #91

Open
MikeTheCanuck opened this issue Dec 3, 2017 · 2 comments
Open

Adding eslint generates multiple unmet peer dependencies #91

MikeTheCanuck opened this issue Dec 3, 2017 · 2 comments

Comments

@MikeTheCanuck
Copy link
Owner

Installed eslint (with airbnb styles, react=true and JSON config file) in the eslint-enable branch.

Now when I fire the yarn command in this branch, it results in these warnings:

$ yarn
yarn install v1.3.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > eslint-plugin-import@2.8.0" has unmet peer dependency "eslint@2.x - 4.x".
warning " > eslint-config-airbnb@16.1.0" has unmet peer dependency "eslint@^4.9.0".
warning "eslint-config-airbnb > eslint-config-airbnb-base@12.1.0" has unmet peer dependency "eslint@^4.9.0".
warning " > eslint-plugin-jsx-a11y@6.0.2" has unmet peer dependency "eslint@^3 ||^4".
warning " > eslint-plugin-react@7.5.1" has unmet peer dependency "eslint@^3.0.0 || ^4.0.0".
[4/4] 📃  Building fresh packages...
success Saved lockfile.
✨  Done in 3.98s.
@MikeTheCanuck
Copy link
Owner Author

Per #92 putting in place the correct versions of the peer Dependencies reduced this to a single spurious warning that makes no sense on the face of it:

warning " > eslint-config-airbnb@16.1.0" has unmet peer dependency "eslint-plugin-react@^7.4.0".

Makes no sense because that exact package and version is a member of the devDependencies section of the package.json right alongside eslint-config-airbnb@16.1.0:

  "devDependencies": {
    "eslint": "4.9.0",
    "eslint-config-airbnb": "^16.1.0",
    "eslint-plugin-import": "2.7.0",
    "eslint-plugin-jsx-a11y": "^6.0.2",
    "eslint-plugin-react": "7.4.0"
  }

@adam187
Copy link

adam187 commented Jan 23, 2018

@MikeTheCanuck I have same issue in my project. It looks like yarn bug, should be resolved in 1.4.0 yarnpkg/yarn#5088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants