-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG - setting task_execution
to main does not seem to work.
#125
Comments
I might have made a silly mistake when implementing this, but I think that in the very least the log message/relevant docs should be updated because this is very confusing for my tiny brain :( Please let me know if you find something Regards |
Just noticed that a new release is available and fixes this! Oh my god!! Sorry for the disturbance, please let me know if you want me to update the docs/logs in the relevant places, I think I can manage to find some time for that. |
No problem! I respect the time you invested to explain, elaborate and investigate the issue, even though it seemed not to be an issue. What comes to docs, I think the time subpackage (in But the cookbook/examples could be extended. Also, I think the condition handbook is perhaps not in the best state. Originally the string syntax was the preferred one and then I created the condition API which should now be preferred (this is what you used in the example above). Perhaps the docs could also be formatted in a way that the condition API is first explained and then as a subsection the string syntax. Also, this I think is in the wrong place: https://rocketry.readthedocs.io/en/stable/condition_syntax/index.html. Could be in the handbook. But more little things to update in the docs:
I'm very much open for contribution. |
I could start by adding a setup with Gunicorn & the Django Rest Framework, as this is what I'm using right now. My setup is mostly based on the solution proposed in #76, but with some caveats. |
That would be awesome! I'm personally not qualified for writing the documentation regarding how to integrate Rocketry with Django (as I haven't used Django myself) but as it is so used, documentation regarding Rocketry+Django would extend Rocketry's audience quite a lot. |
Awesome, will try to work on it by the end of the week. I have exams this week so I might be busy (& therefore a bit late) but i'll do my best. Regards |
Describe the bug
I want to have periodic tasks running in my main thread, but it does not seem to work. if initialized with nothing, rocketry will:
this is ok because the log messages are helpful in suggesting that I should initialize the Rocketry app with `Rocketry(task_execution='async') or something.
Problem is that when I initialize with (task_execution='main'), the startup fails. It seems that the log message is not up to date because docs suggest using ```python
config={
'task_execution': 'main'
}
Expected behavior
Run the tasks in my main thread and not have the app crash on startup.
Screenshots
and then later on, when the job starts:
Desktop (please complete the following information):
Python version:
3.10.7
Rocketry version:
2.4.1
Django version:
4.1
Additional context
N/A
The text was updated successfully, but these errors were encountered: