Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS - Bigger applications has a bug #159

Closed
sijaira opened this issue Nov 28, 2022 · 1 comment · Fixed by #143
Closed

DOCS - Bigger applications has a bug #159

sijaira opened this issue Nov 28, 2022 · 1 comment · Fixed by #143
Labels
documentation Improvements or additions to documentation

Comments

@sijaira
Copy link

sijaira commented Nov 28, 2022

Is it corrected in the latest version (master branch)?
No

Latest version of the docs: https://rocketry.readthedocs.io/en/latest/

Location in the documentation you wish to improve
Bigger Applications

Describe the problem
If you add the code exactly as is, you get AttributeError: 'Rocketry' object has no attribute 'include_group'.

Suggestion for the fix
Instead of include_group it should be include_grouper
@sijaira sijaira added the documentation Improvements or additions to documentation label Nov 28, 2022
@sijaira
Copy link
Author

sijaira commented Nov 28, 2022

whoops there is a pull request for this change over here: #143

@Miksus Miksus linked a pull request Nov 28, 2022 that will close this issue
Docs/Fix bigger_applications include_group wrong reference #143
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs/Fix bigger_applications include_group wrong reference
1 participant
@sijaira