Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging docs have a typo #66

Closed
sijaira opened this issue Jul 29, 2022 · 2 comments
Closed

Logging docs have a typo #66

sijaira opened this issue Jul 29, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@sijaira
Copy link

sijaira commented Jul 29, 2022

Is it corrected in the latest version (master branch)?
no

Latest version of the docs: https://rocketry.readthedocs.io/en/latest/

Location in the documentation you wish to improve
https://rocketry.readthedocs.io/en/latest/handbooks/logging.html#

Describe the problem

The line below causes an error:

logging.addHander(handler)

Suggestion for the fix

It should be:

logger.addHandler(handler)

@sijaira sijaira added the documentation Improvements or additions to documentation label Jul 29, 2022
@Miksus
Copy link
Owner

Miksus commented Aug 1, 2022

Oh, true. Thanks for spotting!

I'll fix this in the upcoming days (unless anyone else wants).

@Miksus
Copy link
Owner

Miksus commented Aug 15, 2022

Fixed in #72

@Miksus Miksus closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants