Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Changlogs caching too strongly #4

Closed
vdvman1 opened this issue May 14, 2024 · 2 comments
Closed

Java Changlogs caching too strongly #4

vdvman1 opened this issue May 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@vdvman1
Copy link
Collaborator

vdvman1 commented May 14, 2024

The /java/changlog page seems to be caching too strongly on the client side, visiting the page after new versions have been released since the last visit doesn't seem to show the new versions in the version list and doesn't show the correct latest changelog until after doing a full refresh (CTRL+F5 in Chrome on Windows)

This has already been fixed server side in c03c9f4, but it seems to be caching client side too much too. Need to investigate exactly why this is and how to fix it

@MulverineX MulverineX added the bug Something isn't working label Jun 17, 2024
@vdvman1
Copy link
Collaborator Author

vdvman1 commented Jul 11, 2024

After checking the build logs, it appears that next.js is incorrectly detecting /java/changelog as a static page, despite the unstable cache for the latest page having a revalidation time.

It should be possible to solve this by setting

export const dynamic = 'force-dynamic'

or potentially

export const revalidate = 2 /* m */ * 60 /* s/m */

in src/app/java/changelog/page.tsx

@vdvman1
Copy link
Collaborator Author

vdvman1 commented Jul 11, 2024

It does appear to be listed as incremental static regeneration, but that's also the case for the home page which doesn't do any fetching at all, so it's hard to tell when/if Next.JS/Vercel will regenerate the page

There also appears to be a commit related to unstable_cache and static generation in Next.JS on the same day this project was first created, so it's possible that updating Next.JS will fix this issue

@vdvman1 vdvman1 closed this as completed in 795917b Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants