Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hidden Enchants on Item #212

Open
bundabrg opened this issue Dec 31, 2019 · 5 comments
Open

Feature: Hidden Enchants on Item #212

bundabrg opened this issue Dec 31, 2019 · 5 comments
Assignees

Comments

@bundabrg
Copy link
Contributor

Allow currencies to have hidden enchants.

@bundabrg bundabrg self-assigned this Dec 31, 2019
@ImdralRaenwood
Copy link

ImdralRaenwood commented Mar 9, 2020

Hello! Checking in on this too! I haven't yet commented regarding this enhancement (though I've years ago spoken with the developers of this plugin regarding other fixes).

But, my server LOVES gringotts, and we use shopkeepers too.
The issue we have been having is that (using emeralds -1 , iron ingots -2 , gold ingots -3, and diamonds-5 as our currency) folks can simply make their own money.

Yes, we have custom names for the currency. In respective order to the above list, they are the
"Alaesian Jot," "Alaesian L'ahr," "Imperial Ba'hn Piece," and "Imperial Astyr."

They work wonderfully.

However. Players have started mining emeralds and diamonds.
They gain XP, then use anvils simply rename the items to "Alaesian Jot," etc.

Manufacturing money.

Our solution to this has been changing all of the Official Currency to Enchanted Items.

They are all the same as mentioned above, but now the real currencies all have "Fortune III" as an enchantment. This makes it muchhhh more difficult for players to manufacture money, rather than earn it.

It works wonderfully with Shopkeepers.

The issue we are now having is that the moneys are no longer recognized by Gringotts, given the special enchantments. To my understanding, there is no way to add this detail to the config file. But, if there was, this would miraculously solve our problem. For example, it could look like:

value of individual denominations. default: emerald: 1, emerald block: 9

denominations:
- material: emerald
displayname: Alaesian Jot
value: 1
enchantment: Fortune III
- material: diamond
displayname: Imperial Astyr
enchantment: []
value: 5

@bundabrg
Copy link
Contributor Author

bundabrg commented Mar 9, 2020

I'll see if I can implement this soon.

@ImdralRaenwood
Copy link

Thank you so much! Wow!
We were not expected a reply so soon. Thank you greatly!

@ImdralRaenwood
Copy link

Another thought that occurred to me - the enchants do not have to be hidden. On our server we are using enchanted currency with shopkeepers, and it works just fine, showing the fortune III enchantment, for example.

either way could work fine, if one is easier for you to do.

Thanks again for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@bundabrg @ImdralRaenwood and others