Rename custom_params to custom_keys #186
Labels
enhancement
New feature or request
good first issue
Want to contribute, start with this!
measurement
Measurement node
This task consists in renaming:
custom_str_param_list
tocustom_key_str_list
node paramtercustom_str_params
tocustom_keys_str
node paramtercustom_params
tocustom_key
The documentation of the parameters are located here https://minipada.github.io/ros2_data_collection/dc/measurements.html#node-parameters
The reason to do so is that we are not adding custom parameters but custom keys to the JSON.
To do it, I would suggest to do a Ctrl-F an do search and replace.
They are located in:
https://github.com/Minipada/ros2_data_collection/blob/humble/dc_core/include/dc_core/measurement.hpp
https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/include/dc_measurements/measurement.hpp
https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/include/dc_measurements/measurement_server.hpp
https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/src/measurement_server.cpp
Then we should also rename them in the documentation. To run the documentation locally and see your changes, check the FAQ https://minipada.github.io/ros2_data_collection/dc/contributing.html#docs
The text was updated successfully, but these errors were encountered: