Module not found

[tigrenok00]

Hi!
I'm using angular 17 and have installed the following packages:

  "@mintplayer/file-player": "^17.4.0",
  "@mintplayer/ng-player-provider": "^17.0.0",
  "@mintplayer/ng-video-player": "^17.4.0",

In my app.module I have in providers
provideVideoApis(fileLoader),

import {
  provideVideoApis,
  VideoPlayerComponent,
} from "@mintplayer/ng-video-player";
import { fileLoader } from "@mintplayer/file-player";

I am getting the following build errors:

`./src/app/app.module.ts:28:0-53 - Error: Module not found: Error: Can't resolve '@mintplayer/file-player' in 'C:\Work\XXX\src\app'

./node_modules/@mintplayer/ng-video-player/fesm2022/mintplayer-ng-video-player.mjs:4:0-37 - Error: Module not found: Error: Can't resolve '@mintplayer/player-provider' in 'C:\Work\XXX\node_modules\@mintplayer\ng-video-player\fesm2022'
`

Can you help me please?

[PieterjanDeClippel]

npx @angular/cli@17 new videotest

[PieterjanDeClippel]

@tigrenok00 At the moment I'm not yet able to do backport patches. Are you able to upgrade to angular 18? Otherwise I have to modify my setup a bit

[tigrenok00]

Hi @PieterjanDeClippel , thanks for your reply!
I did the ng18 update and now the imports work great.

The only issue I have now is that inline bindings (like url) do not seem to work (I see the video component element being created without content, it doesn't pick up the url):

<div class="vid-preview" *ngIf="currentFile.videoSrc"> <video-player [autoplay]="false" [url]="currentFile.videoSrc" ></video-player> </div>

It only works with programmatic setUrl (which is not ideal as I need to find the component/s with viewChildren and set the corresponding url, also this way it always does autoPlay, so I have to pause manually with a small setTimeout immediately after)

if (this.isVideo) { this.player1?.setUrl(this.currentFile.videoSrc); }

Do you have an idea why the bindings do not work for me?

Thanks!

[PieterjanDeClippel]

@tigrenok00 This doesn't seem to work indeed. I'll take a look at it now

[PieterjanDeClippel]

The following seems to do the trick, so I'll probably need to wait for something there

@Input() public set url(value: string) {
  setTimeout(() => this.setUrl(value), 0);
}
public setUrl(url: string | null) {
  if (this.player) {
    this.player.url = url;
  } else {
    console.warn('player not ready'); // <-- This is hit when there's no delay
  }
}

[PieterjanDeClippel]

@tigrenok00 Should be fixed in #73

[tigrenok00]

@PieterjanDeClippel Thank you, the url input works now! Can you please fix this for the properties of autoPlay, width, height as well? They too don't work in direct binding

[PieterjanDeClippel]

@tigrenok00 I refactored it like this now. The angular package version 18.2.0 should work now

[tigrenok00]

@PieterjanDeClippel Thanks, in 18.2.0 it looks like height is working, but autoPlay=false still not respected when setting url like this. Also, I'm getting this error which I don't believe I had before (the player is playing)
main-PUFX6TX4.js:54 ERROR No player found for url

[PieterjanDeClippel]

Should be fixed now too in @mintplayer/youtube-player version 18.1.2

[tigrenok00]

@PieterjanDeClippel I am using streamable-player and file-player

[PieterjanDeClippel]

@tigrenok00

It seems for streamable (player.js) that the API doesn't emit any events anymore...

The autoplay on file-player and wrong error message should be resolved in this PR