Move AUTH modules into common auth package

Author: naumvd95

kqueen_ui/auth.py

@@ -1,10 +1,23 @@
 from itsdangerous import URLSafeTimedSerializer
 from flask import current_app as app
 from kqueen_ui.api import get_kqueen_client
+from kqueen_ui.config import current_config
 
 import logging
 
 logger = logging.getLogger('kqueen_ui')
+config = current_config()
+
+AUTH_MODULES = {
+    "local": {
+        "label": "Local",
+        "notify": config.get("LOCAL_AUTH_NOTIFY")
+    },
+    "ldap": {
+        "label": "LDAP",
+        "notify": config.get("LDAP_AUTH_NOTIFY")
+    }
+}
 
 
 def authenticate(username, password):

kqueen_ui/blueprints/manager/views.py

@@ -4,7 +4,7 @@
 from flask import Blueprint, current_app as app, flash, jsonify, redirect, render_template, request, session, url_for
 from flask_babel import format_datetime
 from kqueen_ui.api import get_kqueen_client
-from kqueen_ui.config.auth import AuthModules
+from kqueen_ui.auth import AUTH_MODULES
 from kqueen_ui.auth import generate_confirmation_token
 from kqueen_ui.blueprints.ui.utils import generate_password, sanitize_resource_metadata
 from kqueen_ui.generic_views import KQueenView
@@ -171,13 +171,11 @@ class MemberCreate(KQueenView):
     def handle(self, organization_id):
         form_cls = MemberCreateForm
 
-        modules = AuthModules()
-        auth_options = modules.__dict__
-        logger.debug('Available Auth options {}'.format(auth_options))
+        logger.debug('Available Auth options {}'.format(AUTH_MODULES))
 
-        if auth_options:
+        if AUTH_MODULES:
             auth_choices = []
-            for name, options in auth_options.items():
+            for name, options in AUTH_MODULES.items():
                 choice = (name, options.get('label', name))
                 auth_choices.append(choice)
             field_kw = {
@@ -197,7 +195,7 @@ def handle(self, organization_id):
             notify = True
             if hasattr(form, 'auth_method'):
                 auth_method = form.auth_method.data
-                notify = auth_options.get(auth_method, {}).get('notify', True)
+                notify = AUTH_MODULES.get(auth_method, {}).get('notify', True)
             password = ''
             active = True
             if auth_method == 'local':

kqueen_ui/blueprints/ui/views.py

@@ -3,7 +3,7 @@
                    render_template, request, session, url_for)
 from flask_babel import format_datetime
 from kqueen_ui.api import get_kqueen_client
-from kqueen_ui.config.auth import AuthModules
+from kqueen_ui.auth import AUTH_MODULES
 from kqueen_ui.auth import authenticate, confirm_token, generate_confirmation_token
 from kqueen_ui.generic_views import KQueenView
 from kqueen_ui.utils.email import EmailMessage
@@ -200,13 +200,10 @@ class UserInvite(KQueenView):
     def handle(self):
         form_cls = UserInviteForm
 
-        modules = AuthModules()
 
-        auth_options = modules.__dict__
-
-        if auth_options:
+        if AUTH_MODULES:
             auth_choices = []
-            for name, options in auth_options.items():
+            for name, options in AUTH_MODULES.items():
                 choice = (name, options.get('label', name))
                 auth_choices.append(choice)
             field_kw = {
@@ -228,7 +225,7 @@ def handle(self):
             notify = True
             if hasattr(form, 'auth_method'):
                 auth_method = form.auth_method.data
-                notify = auth_options.get(auth_method, {}).get('notify', True)
+                notify = AUTH_MODULES.get(auth_method, {}).get('notify', True)
             password = ''
             active = True
             if auth_method == 'local':

kqueen_ui/config/auth.py

@@ -59,7 +59,6 @@ class BaseConfig:
     # Authentication choices
     LDAP_AUTH_NOTIFY = False
     LOCAL_AUTH_NOTIFY = True
-    AUTH_OPTIONS = {}
 
     @classmethod
     def get(cls, name, default=None):

kqueen_ui/config/base.py

@@ -2,7 +2,7 @@
 
 
 class Config(BaseConfig):
-    DEBUG = False
+    DEBUG = True
     LOG_CONFIG = 'kqueen_ui/utils/logger_config.yml'
 
     # CSRF settings