Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Forge #3

Open
Mirsario opened this issue Dec 19, 2020 · 7 comments
Open

Port to Forge #3

Mirsario opened this issue Dec 19, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@Mirsario
Copy link
Owner

Mirsario commented Dec 19, 2020

Plenty of people want this. And, if I remember correctly, there's a rather simple EntityViewRenderEvent.CameraSetup in forge, so this shouldn't be too difficult.

@Mirsario Mirsario added the enhancement New feature or request label Dec 24, 2020
@pa1nki113r
Copy link

That's great news! Happy to test out any prototype in the future

@Neko2n
Copy link

Neko2n commented Feb 4, 2021

@CorgiTaco
Copy link

CorgiTaco commented Feb 4, 2021

It was done by me, but for some reason github wont let me PR it to this repo 😭. Do you want me to add you to the curse project or to my fork of this repo? @Mirsario

@Mirsario
Copy link
Owner Author

Mirsario commented Feb 5, 2021

It was done by me, but for some reason github wont let me PR it to this repo 😭.

You probably can't PR it because, for one, you started a branch without basing it on any other, so the history is from scratch, and, for second, the target branch would be one with "fabric" in its name. Though the latter can be fixed by me after a PR is made.

Do you want me to add you to the curse project or to my fork of this repo? @Mirsario

Add me to the fork and I'll fix its history for a PR to work. As for curse, I personally would heavily prefer for the original one to have forge releases together with fabric ones, if you don't mind. Otherwise, technically, the license means that you can do anything, and I'll respect it.

@CorgiTaco
Copy link

CorgiTaco commented Feb 5, 2021

Alright I sent you an invite, feel free to fix the history. Ill delete the curse page aswell once you've got it uploaded on the fabric page. BUT TBH it's much easier for users to have separate pages for this mod IMO. Bc if you have fabric releases, people will complain andddd if the fabric category is there, forge users will just skip over it.

@Vaalley
Copy link

Vaalley commented Feb 11, 2021

That's amazing news! I was hoping to use that mod on my modpack. Also is there a 1.15.2 version in the pipes?

@lartts
Copy link

lartts commented Feb 14, 2021

I recommend adding [FORGE & FABRIC] in the mod title so people could know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants