Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential dependency conflicts between NoDB and botocore #25

Open
NeolithEra opened this issue Jul 31, 2019 · 3 comments
Open

Potential dependency conflicts between NoDB and botocore #25

NeolithEra opened this issue Jul 31, 2019 · 3 comments
Assignees
Labels
bug Waiting on PyPI Fixed in Master, waiting on PyPI to be updated

Comments

@NeolithEra
Copy link

Hi, as shown in the following full dependency graph of NoDB, NoDB requires botocore (the latest version), while the installed version of s3transfer(0.2.1) requires botocore>=1.12.36,<2.0.0.

According to Pip's “first found wins” installation strategy, botocore 1.12.199 is the actually installed version.

Although the first found package version botocore 1.12.199 just satisfies the later dependency constraint (botocore>=1.12.36,<2.0.0), it will lead to a build failure once developers release a newer version of botocore in the near future, which is greater than 2.0.0.

Dependency tree--------

NoDB(version range:)
| +-appdirs(version range:>=1.4.3)
| +-boto3(version range:>=1.4.4)
| +-botocore(version range:>=1.5.38)
| +-docutils(version range:>=0.13.1)
| +-funcsigs(version range:>=1.0.2)
| +-futures(version range:>=3.0.5)
| +-jmespath(version range:>=0.9.2)
| +-packaging(version range:>=16.8)
| +-pbr(version range:>=2.0.0)
| +-pyparsing(version range:>=2.2.0)
| +-python-dateutil(version range:==2.6.0)
| +-s3transfer(version range:>=0.1.10)
| | +-botocore(version range:>=1.12.36,<2.0.0)
| +-six(version range:>=1.10.0)

Thanks for your attention.
Best,
Neolith

@NeolithEra
Copy link
Author

Solution

  1. Fix your direct dependencies to be botocore>=1.12.36,<2.0.0 and s3transfer==0.2.1, to remove this conflict.
    I have checked this revision will not affect your downstream projects now.

  2. Remove your direct dependency chardet, and use the library botocore transitively introduced by s3transfer.

@Miserlou Please let me know your choice.
I can submit a PR to fix this issue.

@bendog
Copy link
Collaborator

bendog commented Sep 12, 2019

this is resolved in #26

@bendog bendog added the bug label Sep 12, 2019
@bendog bendog self-assigned this Sep 12, 2019
@bendog
Copy link
Collaborator

bendog commented Nov 18, 2019

merged now.

@bendog bendog closed this as completed Nov 18, 2019
@bendog bendog reopened this Nov 18, 2019
@bendog bendog added the Waiting on PyPI Fixed in Master, waiting on PyPI to be updated label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Waiting on PyPI Fixed in Master, waiting on PyPI to be updated
Projects
None yet
Development

No branches or pull requests

2 participants