Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to headers in journal pages don't work #1273

Closed
2 tasks done
superseva opened this issue Oct 6, 2022 · 3 comments
Closed
2 tasks done

Links to headers in journal pages don't work #1273

superseva opened this issue Oct 6, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@superseva
Copy link

superseva commented Oct 6, 2022

Prerequisites.

  • Are you running the latest version of both Foundry VTT and Call of Cthulhu 7th Edition?
  • Have you tested whether the bug persists without any other modules activated or on Foundry Launch in Safe Configuration?

Description.

Create an UUID link that uses # to link to a header tag in some other journal page.
This should be default Foundry behavior

Expected Behavior.

Links like @uuid[JournalEntry.tgwST2KeEd3tqW7O.JournalEntryPage.hk1Ks8kNl4RA4R2a#my-header]{My Header}
should open journal page and scroll to header.

Actual Behavior.

Journal page opens but it doesn't scroll to the header.
This also causes problems with other links that are using hashtag # in their url to send optional attributes to the links. (Like PDF Pager is sending page number after the # symbol

Screenshots.

Possible Fix.

@snap01
Copy link
Collaborator

snap01 commented Oct 8, 2022

A fix for this should be included in the next release

@snap01
Copy link
Collaborator

snap01 commented Oct 18, 2022

Can you please confirm if this issue can be closed with the latest 0.9.2 release?

@superseva
Copy link
Author

It works as it’s intended now. Fixed.

@snap01 snap01 closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants