-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested improvements to CoCids and localization #1584
Comments
The current plan is for items (skills, weapons, books, etc) to be distributed in compendiums. |
Hey, James, thanks for comment. When first ids appeared in RQG (thanks to @wake42 and @Moonpile) I think the core idea of it was to make localization easy. Was an amazing idea that allow to have documents in different languages allowing the user to be shown their localization counterpart. As currently is, I think we are half the way of achieving it. We’ve been discussing lately at discord development server about it, and I mentioned constantly updating ids might severely impact the db performance, so @wake42 suggested to create a macro/function to update ids on demand. My (probably profane) thoughts is that a way not to update documents constantly is:
|
I tried to summarize how I see rqid:s in the documentation page for RQG: https://sun-dragon-cult.github.io/rqg-system/api/rqid It's a bit on the long side, but I've tried to keep it as short as possible without loosing detail. Currently there is no way to switch language of a world, but I agree with @lozanoje that it should be possible to manually initiate such a switch. I've also thought a bit more about if world documents always should have higher prio compared to compendium documents, and again I agree with @lozanoje that they probably should not. Priority should be the compared across world and compendium documents alike. In RQG the rqid, priority and language are added to what is indexed about compendiums, so it should not be a big performance hit to do this I think. |
For me it's also confusing that somehting with higher priority on a compendium in the end has less priority than something in the world with a lesser priority. I agree that priority should be the compared across world and compendium documents alike |
Hey, I've just released a new version of my spanish CoC7 translation module and I've added two macros:
The update procedure is: replace all names and descriptions on an actor based on the cocid - chooses the highest priority among those in the same language of the world - searches in world and compendia items alike Might contain issues |
Finally, took the time to read the entire document. Brilliantly explained, also, learned some stuff I didnt know about rqgids, thanks, mate! |
A change for this should be in the next release When getting documents from compendiums they are now kept as indexes until all sorting and best filtering has been performed. The scope type match has been removed. Now the process is
|
An additional change for this should be in the next release On the left hand menu bar for Keeper's tools there is a new button for updating Actors with the following options
|
Great, thank you! |
Several issues with CoCids and localization
If I understand right, cocid were created to make localization easy, having several documents in different languages with same cocid, might show each client the version on her language, if cocid matches.
Currently CoCids works as follows: in the character sheet, if there is a skill with a cocid, then searches for all the skills in the world with the same cocid and shows the one with higher priority. Also, there is a priority for world documents over compendium/modules.
First issue: Currently it is not working as it is suposed to be, if I create a skill in the world with Spanish name and higher priority than the one in a character sheet (of a pregen, for instance), it doesnt change to the spanish name in the char sheet - not sure if this is the expected behaviour.
Second issue: the priority of world documents over module documents (in compendium) makes imposible to override world documents. Scenario: premium content imports equipment with cocid to the world, I activate a translation module with the same equipment (cocid) with spanish name and wont be translated because world documents precedes module documents.
Third issue: when using cocid maybe (I am not totally sure on this) cocids in the same language of the client language should always precede other languages documents with the same cocid.
The text was updated successfully, but these errors were encountered: