Fix new VM password lookup #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes `store_password` would do a `query_async_job_result` with an empty job id. This is because `@server` would be updated using fog's `list_virtual_machines` which returns an empty jobid field once the deploy job has completed. This commit fixes that by saving the deploy job id to a variable to be used by `store_password` Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
shoekstra
force-pushed
the
fix_vm_password_lookup
branch
from
3499a31
to
789a7dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
store_passwordwould do aquery_async_job_resultwith anempty job id. This is because
@serverwould be updated using fog'slist_virtual_machineswhich returns an empty jobid field once thedeploy job has completed.
This commit fixes that by saving the deploy job id to a variable
to be used by
store_passwordSigned-off-by: Stephen Hoekstra shoekstra@schubergphilis.com