Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

love-release does not make .love file #65

Closed
HDictus opened this issue Jun 25, 2019 · 3 comments
Closed

love-release does not make .love file #65

HDictus opened this issue Jun 25, 2019 · 3 comments

Comments

@HDictus
Copy link
Contributor

HDictus commented Jun 25, 2019

I'm running lua 5.1 on ubuntu 18.04 the conf.lua in question is

function love.conf(t)
  t.releases = {
     title = 'particles',
     package = '-',
     loveVersion = '11.2',
     version = nil,
     author = nil,
     email = nil,
     description = nil,
     homepage = nil,
     identifier = nil,
     excludeFileList = { ''} ,
     compile = false,
     projectDirectory = '<dir>/particles/.',
     releaseDirectory = '<dir>/particles/release',
  }
end

In <dir>, I run love-release particles/release particles -W and I get

/usr/bin/lua5.1: ...local/share/lua/5.1/love-release/scripts/windows.lua:46: particles.love: No such file or directory
stack traceback:
	[C]: in function 'assert'
	...local/share/lua/5.1/love-release/scripts/windows.lua:46: in function 'release'
	...local/share/lua/5.1/love-release/scripts/windows.lua:82: in function <...local/share/lua/5.1/love-release/scripts/windows.lua:77>
	(tail call): ?
	/usr/local/share/lua/5.1/love-release/pipes/args.lua:108: in function 'args'
	...cks/rocks-5.1/love-release/2.0.12-2/bin/love-release:11: in main chunk
	[C]: ?

And indeed there is no particles.love anywhere.
If I create a .love file myself and put it in particles/release it runs to completion
script:createLoveFile is called, but somehow the result isn't written to file.

@HDictus
Copy link
Contributor Author

HDictus commented Jun 26, 2019

I've been having a look at it, and it seems that there isn't anything in project:fileList(). All there is to add for this project is conf.lua and main.lua

@HDictus
Copy link
Contributor Author

HDictus commented Jun 29, 2019

By default, it seems that the string '' is added to excludeFileList, which matches every string for indices 0, 1. This was resulting in every file being excluded.
I'm thinking it'd be best to ensure '' exclude no file in isExcluded

@MisterDA
Copy link
Owner

Fixed by PR #66 and commit 5be593f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants