Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ordering of LogEvents. #47

Closed
projektsdb opened this issue Mar 26, 2018 · 9 comments
Closed

Preserve ordering of LogEvents. #47

projektsdb opened this issue Mar 26, 2018 · 9 comments

Comments

@projektsdb
Copy link

We need to get log events in the same order as they were written, but TestCorrelator.GetLogEventsFromCurrentContex result is randomly ordered (all timestamp values are the same).

@MitchBodmer
Copy link
Owner

MitchBodmer commented Mar 28, 2018

Hey @projektsdb. Check this preview version out and see if it works for you. If it does I'll complete this PR and publish the Nuget package.

@MitchBodmer MitchBodmer changed the title TestCorrelator.GetLogEventsFromCurrentContex is randomly ordered Preserve ordering of LogEvents. Mar 28, 2018
@projektsdb
Copy link
Author

The system cannot find the file specified.":"System.ValueTuple.
There is some version mismatch. Not sure why.

@MitchBodmer
Copy link
Owner

How are you installing the preview version?

@MitchBodmer
Copy link
Owner

MitchBodmer commented Mar 30, 2018

Try this if you haven't already:

  • Copy the preview version of the Nuget package to a local directory on your machine.
  • Add that directory as a Nuget package source in Visual Studio.
  • Install the package using the package manager UI in Visual Studio.

@MitchBodmer
Copy link
Owner

@projektsdb have you had a chance to try?

@projektsdb
Copy link
Author

When I install it as nucket pagacke into my project, it throws System.ValueTuple when I run project.

@MitchBodmer
Copy link
Owner

This bug might be the cause here. In any case, I've removed the reference to System.ValueTuple in this preview version. Give it a shot.

@projektsdb
Copy link
Author

This works well. After some testing it seems that ordering also is correct.

@MitchBodmer
Copy link
Owner

Great! I've completed the PR and it should show up in the package feed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants