Provide success as a second argument to RequestOptions.deserialize

[romme]

Long time user of the framework here. Actually it's the only framework i ever used, but nevermind, on to the feature request.

In case of REST apis which indicate failure or success as http status codes it may be cumbersome to tell error and success apart from the response object alone. Fortunately, Mithril already looks at the http status code and rejects the promise appropriately. But in case the promise is going to be rejected soon it may be undesireable to call deserialize on the response payload. What about adding a second argument to it so deserializing could be skipped?

try {
    this.backend_response = await m.request({
        url,
        deserialize(response) {
            if (!(response instanceof Array)) // very crude attempt to tell a json payload from a json error object
                return response;
            for (var row of response) // response does not have an "error" field we could easily look for
                row.Date = new Date(t.Date);
            return response;
        },
    });
} catch (e) {
    alert(e.message); // in this case a json error object is a string
}

After implementing this feature:

try {
    this.backend_response = await m.request({
        url,
        deserialize(response, success) {
            if (!success)
                return response;
            for (var row of response)
                row.Date = new Date(t.Date);
            return response;
        },
    });
} catch (e) {
    alert(e.message);
}

After writing all of this i realized that i could just deserialize manually after resolving the promise, which i'm going to do now. Still going to post this as an excuse to thank you for the great framework.

[osban]

@romme maybe you could deal with things using the extract method, something like this?

[romme]

@osban that's rougly the same amount of code, went with this in the end

[osban]

@romme Ah cool. Yeah I wasn't quite sure how much control you needed, so if this works, it's the best option 🙂