Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why should m.request and m.jsonp be split? #2367

Closed
dead-claudia opened this issue Feb 1, 2019 · 0 comments
Closed

Why should m.request and m.jsonp be split? #2367

dead-claudia opened this issue Feb 1, 2019 · 0 comments
Milestone

Comments

@dead-claudia
Copy link
Member

Description

Currently, m.request and m.jsonp are split. This was introduced in v1 per #1068

I'm proposing for v3, let's move that back to m.request via the special method: "JSONP" (case-insensitive). We'd just ignore callbackKey and callbackName for non-JSONP requests, and user-visible handling is otherwise identical.

Why

Leo's justification doesn't really hold up from a usability perspective. It really feels like it's leaking an implementation detail.

Plus, with modern CORS, JSONP has mostly just disappeared now, so we might be able to get away with just dropping it. It's been literally years since I've last needed to make a script request, and CORS is fully supported in IE10+. If we really wanted to support IE8-9, we could fall back to XDomainRequest on network failure for partial support, at the cost of moderately increased latency for those two browsers specifically. (It supports about 80% of XHR's API.)

Possible Implementation & Open Questions

The implementation is self-explanatory. The main question of this bug is really this: do we want to keep them separate, combine them, or drop m.jsonp's functionality altogether?

Is this something you're interested in working on?

Yes

@dead-claudia dead-claudia added the v3 label Feb 1, 2019
@dead-claudia dead-claudia added this to the v3 milestone Jul 24, 2019
@dead-claudia dead-claudia removed the v3 label Jul 24, 2019
@MithrilJS MithrilJS locked and limited conversation to collaborators Jan 29, 2022
@orbitbot orbitbot converted this issue into discussion #2734 Jan 29, 2022
@dead-claudia dead-claudia moved this to Under consideration in Feature requests/Suggestions Sep 2, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
Status: Under consideration
Development

No branches or pull requests

1 participant