Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong archive links when already in archive #2832

Closed
tbreuss opened this issue May 1, 2023 · 1 comment · Fixed by #2839
Closed

Wrong archive links when already in archive #2832

tbreuss opened this issue May 1, 2023 · 1 comment · Fixed by #2839
Assignees
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@tbreuss
Copy link
Contributor

tbreuss commented May 1, 2023

When we are viewing an archived version and we try to change to another version, this results in a 404 page not found error. This is quite annoying.

See screenshots.

  1. Here we are in a archived version:

  1. And this is the 404

The solution to the problem consists of two parts:

  1. Edit the generator-docs.js script

Simply add a slash at line https://github.com/MithrilJS/mithril.js/blob/next/scripts/generate-docs.js#L98. I have a commit in a docs-update branch.

  1. Edit generated gh-pages

For already archived docs we have to edit content at https://github.com/MithrilJS/mithril.js/tree/gh-pages/archive, if we wan't to fix this.

@tbreuss
Copy link
Contributor Author

tbreuss commented May 2, 2023

Fixed with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants