Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

enable sourcemap output other than inline #38

Closed
lionelB opened this issue Sep 27, 2014 · 8 comments
Closed

enable sourcemap output other than inline #38

lionelB opened this issue Sep 27, 2014 · 8 comments

Comments

@lionelB
Copy link
Contributor

lionelB commented Sep 27, 2014

Since cssnext only return process().css, sourcemap is only suported when inlined in output. If specific sourcemap options are provided to postcss ( map, from) process() return an object with {css: "output", map: "sourcemap"}
To avoir breaking changes, perhaps cssnext should return an object only if postcss return map prop.

@MoOx
Copy link
Owner

MoOx commented Oct 9, 2014

I don't use sourcemap (don't feel the need to), so feel free to take care of that.
PRs are always welcome :)

@lionelB
Copy link
Contributor Author

lionelB commented Oct 9, 2014

Have in mind that the output of the postcss will change, and so the api of cssnext
(don't know how to deal with wemver anymay :D )

@MoOx
Copy link
Owner

MoOx commented Oct 9, 2014

It's not a problem. Don't think about semver now. We are below 1.0, so we can add breaking changes. And after 1.0, breaking changes will just bump to a major version.
We can (like you said) return the object if sourcemap is not inlined.

@lionelB
Copy link
Contributor Author

lionelB commented Oct 9, 2014

okidoki i'll take it ;)

@Subash
Copy link

Subash commented Oct 22, 2014

Any update on this ? I a trying to include this inside Prepros.

@MoOx MoOx closed this as completed in 5b34e48 Oct 23, 2014
@lionelB
Copy link
Contributor Author

lionelB commented Oct 23, 2014

thx!

@MoOx
Copy link
Owner

MoOx commented Oct 23, 2014

@Subash change released as 0.4.0
Tell me if you need anything ;)

@Subash
Copy link

Subash commented Oct 23, 2014

@MoOx Thanks, added to Prepros 5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants