Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Member #20

Closed
yudielcurbelo opened this issue Dec 6, 2023 · 6 comments · Fixed by #27
Closed

Virtual Member #20

yudielcurbelo opened this issue Dec 6, 2023 · 6 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers waiting for release

Comments

@yudielcurbelo
Copy link

When using EF Core Lazy Loading Dump() will load the whole tree.
Using MaxDepth = 1 helps, but then you will see a lot of [Exceeded max depth 1] in the console.
Is there a way to limit the library to ignore virtual members.

@MoaidHathot MoaidHathot self-assigned this Dec 6, 2023
@MoaidHathot MoaidHathot added the enhancement New feature or request label Dec 6, 2023
@MoaidHathot
Copy link
Owner

MoaidHathot commented Dec 6, 2023

Hi @yudielcurbelo, interesting use case!
Do you mean to ignore all members (also inherited) that is marked with the virtual keyboard?
I'm not proficient enough with EF Core, is there another way to determine which members are currently "lazy" loaded? Will the compiler/EF-Core add some attributes to the members? I'm asking to determine whether there is a more precise way to filter lazy-loaded members in this context.

I can add configuration to ignore virtual members, it should be easy. I will look into it this weekend.

@MoaidHathot MoaidHathot added the good first issue Good for newcomers label Dec 6, 2023
@Empiree
Copy link
Contributor

Empiree commented Mar 14, 2024

Hi @yudielcurbelo, interesting use case! Do you mean to ignore all members (also inherited) that is marked with the virtual keyboard? I'm not proficient enough with EF Core, is there another way to determine which members are currently "lazy" loaded? Will the compiler/EF-Core add some attributes to the members? I'm asking to determine whether there is a more precise way to filter lazy-loaded members in this context.

I can add configuration to ignore virtual members, it should be easy. I will look into it this weekend.

Hello, I really like your project, can I contribute and solve this problem?

As far as I understand, we need to add IncludeVirtualMembers to MembersConfig and depending on this value output virtual members.

@MoaidHathot
Copy link
Owner

MoaidHathot commented Mar 14, 2024

Hi @Empiree, thanks!
Basically, yeah. Most of the changes should be inside MemberProvider. I would love to get help :)

@Empiree
Copy link
Contributor

Empiree commented Mar 15, 2024

Hi @Empiree, thanks! Basically, yeah. Most of the changes should be inside MemberProvider. I would love to get help :)

It's done! If any changes are needed, I'll be happy to fix them :)

@MoaidHathot
Copy link
Owner

Thanks @Empiree and sorry for the delay in response. I'll review it tomorrow :)

@MoaidHathot
Copy link
Owner

Thanks @Empiree for your contribution, I've approved the PR. The change should be part of the next release, towards the end of March :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers waiting for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants