Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required files and API results #170

Closed
AntoineAugusti opened this issue Feb 14, 2024 · 2 comments · Fixed by #175
Closed

Missing required files and API results #170

AntoineAugusti opened this issue Feb 14, 2024 · 2 comments · Fixed by #175
Assignees

Comments

@AntoineAugusti
Copy link
Contributor

Follow up of #127 and the fix introduced in #169

What is the issue and why is it an issue?

When a file is missing but required, the API now says

"summary": {
  "errorsCount": 0,
  "hasErrors": true
}

image

which seems unexpected.

Example

Proposed fix

errorsCount should be the sum of GBFS errors + the number of missing required files

@jcpitre
Copy link
Contributor

jcpitre commented Apr 2, 2024

Some work has been done on a similar issue: #169

@AntoineAugusti
Copy link
Contributor Author

Thank you for the fix @Alessandro100! It works: example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants