-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vehicle_capacity and vehicle_type_capacity #251
Comments
+1 Good catch, it is really not clear that vehicle_capacity relates to station_area. We're not implementing these fields, but I think renaming this to station_area_capacity or similar would make it a lot clearer. The description reads fine. |
Since both of these refer to available parking space, as opposed to the capacity of vehicles, I suggest renaming to |
How important is it that "vehicle_type" be included in the names of the fields themselves? Is it sufficient for it to be mentioned in the description of the field? Adding vehicle type may make things lengthy. Additionally, the fields themselves should ideally clarify that |
My votes are for
I'd also vote to re-order the docs to put all 3 capacity-related fields adjacent to one another to avoid scrolling to read the different definitions. |
Without wanting to further complicate things... I note that in the station_status.json, the current dock availability allows the description of docks that can support multiple vehicle types (ie vehicle_docks_available is an array of an array of vehicle_type_ids). It seems therefore that the descriptions in station_status and station_information have rather diverged. So an example: 3 types of vehicle: V1, V2, V3. In the current proposal this seems to be represented as: station_information: station_status Two questions : i) are we happy with this difference ? ii) should we align any name changes such that perhaps "vehicle_docks_available" becomes "vehicle_type_dock_available" ? |
Closing this out - This issue is captured in PR #269 which is currently open for vote until 11:59PM UTC on October 13th, 2020. Please get on over there and vote. |
After reviewing the specification, MobilityData has realized the differentiation between
vehicle_capacity
andvehicle_type_capacity
is not extremely clear. This is due, in part, to both thegeofencing.json
andvehicle_types.json
extensions occurring concurrently. As a result, both of these fields were not able to be viewed in tandem before being merged into the specification.vehicle_capacity
is defined as:vehicle_type_capacity
is defined as:Given that v2.1 is still in RC, we feel these fields should be clarified before an official release. What would be the best way to do that?
vehicle_capacity
? (ex:station_area_capacity
,vehicle_type_area_capacity
,vehicle_type_virtual_capacity
, etc.)vehicle_type_capacity
? (ex:vehicle_type_dock_capacity
, or others)Please let us know what you think and if you're implementing these fields!
The text was updated successfully, but these errors were encountered: