-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should StopTimeUpdates be propagated across trips in the same block? #27
Comments
Comment by barbeau I've drafted an diagram to help explain this issue - https://docs.google.com/presentation/d/1bLV8QaQkGARX1g1ThdQr9mf7oOCGs3db2VH9TsZ-tgw/edit |
Comment by barbeau I was looking at how OneBusAway handles early arrivals for Trip A (i.e., a negative delay value).
|
Comment by barbeau GTFS-rt proposal now open at google/transit#110. |
Comment by minhhpham I added a rule to this branch to check whether a
|
Comment by barbeau @minhhpham could you add a link to snippets Gist here too? Also, please review the data and mark any agencies that have more than one stop_time_updates. I know that MBTA, and I think OVapi, have multiple stop_time_updates for some (maybe most) trips. The tool may have flagged some of these as having only one |
Comment by minhhpham The previous comment lists agencies with at least 1
I also updated the validator branch. |
Comment by minhhpham Here's the Gist: https://gist.github.com/minhhpham/1f3baa8715edf859087ba1dd061b2cb1 |
Comment by barbeau @minhhpham Thanks for pulling this together! I think we need one more piece of data here, which is how many agencies are providing feeds that give more than one |
Comment by minhhpham For the % of vehicles, I think we can just count the total number of |
Comment by barbeau Within the
It's probably enough to just get the agency name for the first agency and write it as the file name for that data. |
Comment by minhhpham Here are 18 agencies with duplicated vehicle_id (i.e., more than one trip_update per vehicle simultaneously):
|
Comment by barbeau Thanks! And what's the total number of agencies analyzed? The remainder are the ones this issue applies to. |
Comment by minhhpham Total is 46 agencies, so 28 don't have more than one simultaneous trip_update per vehicle. |
Comment by barbeau @minhhpham Ok, thanks, this is great. However, I think there is one last corner case that we need to address. Of the remaining 28 that don't have more than one simultaneous trip_update per vehicle (based on the above analysis), this could be due to the Could you please do one more pass to see how many agencies are missing EDIT - I changed the "aren't" to "are" in the above question. |
Comment by minhhpham The validator that I wrote actually provides this information because it spits out the total number of |
Comment by barbeau Ok, thanks! So that would mean that 20 out of the 46 agencies (43%) are definitely not providing more than one simultaneous trip_update per vehicle (based on the time of day analyzed). The 8 without vehicle_ids may or may not be providing this - it's impossible to tell without cross-referencing the GTFS and doing a more in-depth analysis. |
Comment by minhhpham That's correct. |
Issue by barbeau
Monday Mar 27, 2017 at 17:14 GMT
Originally opened as CUTR-at-USF#90
Summary:
To my knowledge, currently it's not clear whether or not consumers should propagate StopTimeUpdates across trips in the same block. It IS clear that updates should be propagated within the same trip.
See my comment on item 4 here:
https://groups.google.com/d/msg/gtfs-realtime/Ua8f2AFQ9U4/EDTPDuEcAgAJ
Excerpt:
I don't think this affects our validator at all, but I wanted to capture this here with the "GTFS-rt spec clarification" so I can revisit this in the GTFS-rt community.
The text was updated successfully, but these errors were encountered: