Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links from the HTML documentation to the online documentation are not working #1626

Closed
isabelle-dr opened this issue Dec 20, 2023 · 2 comments · Fixed by #1629
Closed

Links from the HTML documentation to the online documentation are not working #1626

isabelle-dr opened this issue Dec 20, 2023 · 2 comments · Fixed by #1629
Labels
bug Something isn't working (crash, a rule has a problem)

Comments

@isabelle-dr
Copy link
Contributor

Describe the bug

The HTML report provides links to our online documentation via a "You can see more about this notice here" statement.

These links are structured as https://gtfs-validator.mobilitydata.org/rules.html#notice_name in the report.

The anchors in the documentation are structured as https://gtfs-validator.mobilitydata.org/rules.html#notice_name-rule

The missing -rule at the end means the links on the HTML report bring the users to the top of the documentation page as a result instead of to the exact location of the rule doc.

Steps/Code to Reproduce

  • Validate any GTFS dataset
  • Expand a rule and click on the link that redirects to our online documentation

Expected Results

I land directly at the location of the rule in the doc

Actual Results

I land at the top of the document

Screenshots

No response

Files used

No response

Validator version

4.2.1

Operating system

MacOS

Java version

No response

Additional notes

No response

@isabelle-dr isabelle-dr added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels Dec 20, 2023
@github-project-automation github-project-automation bot moved this to Requires investigation in Bug triage Dec 20, 2023
@bradyhunsaker
Copy link
Contributor

Looks like this and issue #1608 are duplicates.

@jcpitre
Copy link
Contributor

jcpitre commented Jan 3, 2024

Duplicate of #1608

@jcpitre jcpitre marked this as a duplicate of #1608 Jan 3, 2024
@jcpitre jcpitre closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@github-project-automation github-project-automation bot moved this from Requires investigation to Done in Bug triage Jan 3, 2024
@emmambd emmambd added this to the Now milestone Jan 9, 2024
@emmambd emmambd removed the status: Needs triage Applied to all new issues label Jan 9, 2024
@emmambd emmambd removed this from the Now milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants