Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gradle-wrapper.jar is not up-to-date with gradle version. #1655

Closed
HappyHacker123 opened this issue Jan 21, 2024 · 4 comments · Fixed by #1677
Closed

The gradle-wrapper.jar is not up-to-date with gradle version. #1655

HappyHacker123 opened this issue Jan 21, 2024 · 4 comments · Fixed by #1677
Assignees
Labels
enhancement New feature request or improvement on an existing feature

Comments

@HappyHacker123
Copy link

Describe the problem

Currently gtfs-validator is using gradle 7.4 as mentioned in gradle-wrapper.properties and the checksum of current wrapper.jar is 33ad4583fd7ee156f533778736fa1b4940bd83b433934d1cc4e9f608e99a6a89. However, as can be seen from official doc https://gradle.org/release-checksums/, the expected checksum of wrapper.jar 7.4 should be 575098db54a998ff1c6770b352c3b16766c09848bee7555dab09afc34e8cf590. The inconsistency means that the wrapper.jar is stale and should be updated.

Possible Solution

Proposed solution

As mentioned in gradle official document https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper, you will need to run the wrapper task a second time to make sure the wrapper.jar is updated. You can run the below command in the root project. Automatically the wrapper scripts will be generated by gradle with corresponding version.

bash gradlew wrapper

Alternatives you've considered

No response

Additional context

No response

@HappyHacker123 HappyHacker123 added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels Jan 21, 2024
Copy link

welcome bot commented Jan 21, 2024

Thanks for opening your first issue in this project! If you haven't already, you can join our slack and join the #gtfs-validators channel to meet our awesome community. Come say hi 👋!

Welcome to the community and thank you for your engagement in open source! 🎉

@cka-y
Copy link
Contributor

cka-y commented Feb 7, 2024

👋 @HappyHacker123! Thanks for highlighting the checksum mismatch with our gradle-wrapper.jar. You're right -- this discrepancy suggests that our wrapper might be outdated or incorrectly set up. We will take a look ASAP!

Feel free to open a PR if you'd like to jump in and help with the update. Your contributions are always welcome!

@qcdyx qcdyx removed the status: Needs triage Applied to all new issues label Feb 20, 2024
@qcdyx qcdyx self-assigned this Feb 20, 2024
@qcdyx qcdyx linked a pull request Feb 20, 2024 that will close this issue
5 tasks
@qcdyx qcdyx mentioned this issue Feb 20, 2024
5 tasks
@qcdyx
Copy link
Contributor

qcdyx commented Feb 20, 2024

Hey @HappyHacker123 Thanks again for posting this issue. A fix is ready for review in this PR #1677.

@HappyHacker123
Copy link
Author

Hey @HappyHacker123 Thanks again for posting this issue. A fix is ready for review in this PR #1677.

Many thanks :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants