Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex: modify foreign_key_violation to support locations.geojson #1757

Open
emmambd opened this issue May 13, 2024 · 1 comment
Open

Flex: modify foreign_key_violation to support locations.geojson #1757

emmambd opened this issue May 13, 2024 · 1 comment
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex. status: Blocked Can't work on it currently because of an external factor.
Milestone
7.0 Validator Rel...

Comments

@emmambd
Copy link
Contributor

emmambd commented May 13, 2024 •
edited
Loading

Describe the problem

We want to be able to support Flex as a part of #1721, we need to refactor current rules to support locations.geojson.

Proposed solution

Modify and test foreign_key_violation when location_id is defined in stop_times.txt but not in locations.geojson. Test with
foreign_key_violation_area_1137.zip to verify.

Alternatives you've considered

No response

Additional context

No response
@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues flex Rules and rule changes related to GTFS-Flex. labels May 13, 2024
@emmambd emmambd changed the title Flex: refactor foreign_key_violation to support locations.gejson Flex: refactor foreign_key_violation to support locations.geojson May 13, 2024
@emmambd emmambd changed the title Flex: refactor foreign_key_violation to support locations.geojson Flex: modify foreign_key_violation to support locations.geojson May 13, 2024
@emmambd emmambd added this to the Flex: modifying pre-existing rules milestone May 14, 2024
@emmambd emmambd added status: Blocked Can't work on it currently because of an external factor. and removed status: Needs triage Applied to all new issues labels May 16, 2024
@emmambd emmambd modified the milestones: Flex: modifying pre-existing rules, 6.0 Validator Release May 30, 2024
@davidgamez
Copy link
Member

Tasks:

  • Change the location_id to conditional and check the location.geojson for the IDS.
  • Review acceptance tests results for flex feeds.

@emmambd emmambd added the flex-2 label Sep 3, 2024
@emmambd emmambd removed this from the 6.0 Validator Release milestone Sep 3, 2024
@emmambd emmambd removed the flex-2 label Sep 9, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex. status: Blocked Can't work on it currently because of an external factor.
Projects
None yet
Milestone
7.0 Validator Release
Development

No branches or pull requests
2 participants
@davidgamez @emmambd