Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: overlapping_zone_and_pickup_drop_off_window #1809

Open
emmambd opened this issue Sep 3, 2024 · 2 comments · May be fixed by #1934
Open

Flex: overlapping_zone_and_pickup_drop_off_window #1809

emmambd opened this issue Sep 3, 2024 · 2 comments · May be fixed by #1934
Assignees
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex. status: Needs triage Applied to all new issues

Comments

@emmambd
Copy link
Contributor

emmambd commented Sep 3, 2024

Describe the problem

In order to complete the tasks outlined in #1750 and calculate overlapping geometries for ERROR overlapping_zone_and_pickup_drop_off_window , we need to be able to parse the geometries.

Proposed solution

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues flex-2 labels Sep 3, 2024
@emmambd emmambd added this to the Future work milestone Sep 3, 2024
@jcpitre
Copy link
Contributor

jcpitre commented Sep 5, 2024

Here is the procedure I believe we should follow for the validation:
In stop_times.txt

  • For all entities with the same trip_ip and with a defined location_id
    • For any 2 entities with the same pickup_type or drop_off_type
      • For any 2 entities with an overlap of pickup_drop_off_window (i.e. for entity 1 start_pickup_drop_off_window -> end_pickup_drop_off_window times overlaps entity 2 start_pickup_drop_off_window -> end_pickup_drop_off_window)
        • If there is any overlap between the 2 geometries
          • Issue the overlapping_zone_and_pickup_drop_off_window notice

@emmambd emmambd removed the flex-2 label Sep 9, 2024
@emmambd emmambd linked a pull request Oct 8, 2024 that will close this issue
5 tasks
@emmambd emmambd changed the title Parse geometries from locations.geojson Flex: overlapping_zone_and_picup_drop_off_window Oct 8, 2024
@emmambd emmambd changed the title Flex: overlapping_zone_and_picup_drop_off_window Flex: overlapping_zone_and_pickup_drop_off_window Oct 9, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label Dec 2, 2024
@qcdyx
Copy link
Contributor

qcdyx commented Dec 9, 2024

  • Documentation review
  • Build logic for checking for overlapping geometries
  • Develop rules
  • Test
  • Check for acceptance test issues

@cka-y cka-y self-assigned this Dec 23, 2024
@cka-y cka-y linked a pull request Dec 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex. status: Needs triage Applied to all new issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants