Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroying instance doesn’t remove all event handlers #15

Closed
niksy opened this issue Jun 15, 2018 · 5 comments
Closed

Destroying instance doesn’t remove all event handlers #15

niksy opened this issue Jun 15, 2018 · 5 comments
Labels
bug

Comments

@niksy
Copy link

niksy commented Jun 15, 2018

When destroying instance with destroy() method, touchstart event handlers are still there.

selectable.min.js:11 Uncaught TypeError: Cannot read property 'start' of undefined
    at a.touchstart (selectable.min.js:11)

I’ve pinpointed issue to these lines of code.

Am I doing something wrong?
@Mobius1 Mobius1 added the bug label Jun 15, 2018
@Mobius1
Copy link
Owner

Mobius1 commented Jun 15, 2018

Is this on a desktop or touch device?

@niksy
Copy link
Author

niksy commented Jun 15, 2018

Chrome Responsive view, so I think it’s touch device.

@Mobius1
Copy link
Owner

Mobius1 commented Jun 15, 2018 •
edited
Loading

Thanks, I'll see if I can reproduce it.

EDIT: I've managed to reproduce it so I'll get a fix out ASAP.

@Mobius1
Copy link
Owner

Mobius1 commented Jun 15, 2018

This should be fixed now. Reopen if required 👍

@MR-AMDEV
Copy link

Getting the following while in chrome desktop

Uncaught TypeError: Cannot set property 'selecting' of undefined
at z._start (selectable.min.js:33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niksy @Mobius1 @MR-AMDEV