-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for game [Fallout New Vegas - Epic Games Release] #1885
Comments
Can you validate that ANY of those manifests would contain the proper game directory or is it safe to just use the base game manifest? |
All of these manifests contain a reference to the directory The extra complication is that this isn't the basegame directory, for the English language install, the subdirectory "Fallout New Vegas English" is the basegame equalivant. Not the same if someone were to install a multilingual verison, eg: "Fallout New Vegas Spanish" is the Spanish version. Whole extra copies of the game - it seems what launches is determined by the EGS language settings and not by the executable that's run. (Yes, the Epic Games patcher works with these versions too. Whether you want to support them right now is up to you!) But yeah, thanks for the quick PR! |
Is it possible to pull that language from an Epic manifest file? |
Are there any other directories within FalloutNewVegas that aren't a valid game directory? I may just opt to select the first directory. |
No, all the subdirectories are game installs. The manifest files do write a tag corresponding to each version. Eg, with both English and Spanish installed: "InstallTags": [
"",
"spanish"
],
Mind, the installation of multiple versions at once is a bit of a contrivance, in practice I'm sure one would be installed at a time, especially as mod installation files would effectively need to be copied over between each and every language if someone really wanted to play multilingual. I think trying to support that is out of scope, first directory should be good enough for 99% of these installs. |
This does make use of some additional changes in gamebryo so I won't be able to just drop in a NV plugin dll, but I'll add it to the next beta build so you can test. |
Just to be sure, |
Yeah, it uses the same directory, just checked. |
@WilliamImm Can you please test with the beta 11 release and let me know how it works? There's some evidence that there might be issues with USVFS hooking the application but it's not clear to me why that is. |
This mostly works, with the critical exception of plugin files not loading. Texture/loose file mods and NVSE plugins do work though. However, this only happens once Without it, mods do not load at all, and weird issues with starting the game up are present, including EGS launching the launcher after the game was closed. That being said, mod plugin files not loading is critical to fix before this is ready for primetime, for obvious reasons. The VFS behavior seems to be working fine, so I'm guessing it's a disconnect in hooking to point to the correct plugin loadorder w/in the game itself. This seems to line up what RJ is reporting in the Discord. Tested with JIP LN NVSE Plugin, YUP, Ultimate Edition Title Screen Replacer, JSawyer Ultimate Edition, and Mod Configuration Menu - stuff that for the most part would be immediately obvious if not present. Some other observations:
I've tested on both patched and non-patched versions, and can confirm this mostly working behavior if and only if -EpicPortal is enabled. mo_interface.log Semi-successful versions |
Also, deux mo_interface.log, in case that helps. |
Noted, and I can make those changes, but it does appear to be finding and loading those plugins: |
One thing I'm not seeing is an open of plugins.txt. This is what I get in my Steam log and I don't see an equivalent one in your log: Can you super double check the plugins.txt file location path? Maybe manually install one and enable it in the launcher and see what file is created. (You can revert it after checking the files.) |
Another relevant difference: Mine: There's some kind of error when it tries to access AppData\Local. |
That might explain why the plugins aren't loading. The location should be Accoding to MS system error codes, 1008 corresponds to "ERROR_NO_TOKEN". That help any? |
And to double check, manually running it through the launcher and adding mods there, |
Can you try running as admin to see if it makes a difference? It seems to be failing to load the file and I'm not sure why. |
That made no difference. Here's my log for that attempt. |
It shows them enabled as well. Assuming those aren't present in the default plugins.txt, that means the launcher is reading and updating the plugins.txt as expected. So, bizarrely, the game is not. Can you try dropping the profile plugins.txt into AppData before running the game just to see if the plugins will load with that? |
I'd also recommend temporarily disabling any antivirus while testing this just to rule out any interference from that. |
...wait. I tested a hypothesis from RJ over on Discord. He was theorizing that the patched version checks FalloutNV in AppData\Local, not FalloutNV_Epic. By copying over the MO plugins.txt over to FalloutNV in AppData, it works. I'm gonna test with the unpatched version, my hypothesis is that both unpatched and patched versions do this. |
By patched, I'm assuming you mean a patched version of the EXE? But the launcher doesn't, so that feels like a patcher bug to me. |
It's not a patcher bug, the unpatched version does this too. I checked with the 1.4.0.1338 (Vanilla epic) exe. The actual plugin.txt path is Whyyyyyyyyy. Why the inconsistency. At least plugins are working. |
Turns out we discovered a pretty major Bethesda-introduced bug with the EGS version, since the vanilla launcher is affected by this too. Yeesh. Virtualizing both directories works for now, but barring an unlikely Bethesda fix, gonna talk with lStewieAl to see if the patcher can resolve this inconsistency. |
It occus to me that the TTW plugin needs matching updates too, so.. made #1891 for tracking that. |
5daeb974a22a435988892319b3a4f476
b290229eb58045cbab9501640f3278f3
562d4a2c1b3147b089a7c453e3ddbcbe
c8dae1ab0570475a8b38a9041e614840
4fa3d8d9b2cb4714a19a38d1a598be8f
7dcfb9cd9d134728b2646466c34c7b3b
ee9a44b4530942499ef1c8c390731fce
Additional Details
Game data version for English is [Epic Games]/FalloutNewVegas/Fallout New Vegas English. FalloutNewVegas contains Launcher.exe and supporting files, including a configuration. Seemingly what's run to launch the game, configuration file can be altered to point at FalloutNV.exe proper to skip this launcher.
Game version is 1.4.0.1338 on Epic at time of this writing, compared to Steam 1.4.0.525. (CRC: 5E871578)
EOSSDK-Win32-Shipping.dll is present. Main differences in files appear to be DLLs in root folder besides this (no GDFFalloutNV.dll by default in Epic release, msvcp140 and vcruntime140 are present)
Does not modify registry by default.
Epic Games Patcher is an effective requirement for modded setups, as it allows for xNVSE to be used. Can check for presence by reading version number (should be 1.4.0.525 after patcher). Potentially suggest users run it if they haven't.
#1828 shows potential launcher interference w/ this title.
The text was updated successfully, but these errors were encountered: