Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trac: Tidy up Python implementation #194

Open
4 of 7 tasks
MichaelClerx opened this issue May 5, 2020 · 0 comments
Open
4 of 7 tasks

Trac: Tidy up Python implementation #194

MichaelClerx opened this issue May 5, 2020 · 0 comments
Labels
code-and-design Code style, architecture

Comments

@MichaelClerx
Copy link
Contributor

MichaelClerx commented May 5, 2020

https://chaste.cs.ox.ac.uk/trac/ticket/2458

Various tasks left over from https://chaste.cs.ox.ac.uk/trac/ticket/2390, that aren't significant enough to warrant their own tickets:

  • Enforce use of an output folder when generating temporary files; perhaps make it a constructor argument.
  • Move the compact syntax parser into the fc package (the script called by C++ can set an environment variable so the module knows what to import).
  • Improve docstrings (mostly copying from the C++ versions). See also Add module level docstrings #16.
  • Also document clearly how to install the required third-party libraries
  • Make Compile indicate whether to evaluate the string using numexpr or eval
  • Check (& maybe fix) behaviour of re-running python tests when imported modules change
    • This is broken for the Python FC implementation at least. It might be that SCons' scanner doesn't understand the relative within-package imports.
@MichaelClerx MichaelClerx added the code-and-design Code style, architecture label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-design Code style, architecture
Projects
None yet
Development

No branches or pull requests

1 participant