Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong test for log1p ? #223

Open
MichaelClerx opened this issue Oct 27, 2020 · 2 comments
Open

Wrong test for log1p ? #223

MichaelClerx opened this issue Oct 27, 2020 · 2 comments

Comments

@MichaelClerx
Copy link
Contributor

MichaelClerx commented Oct 27, 2020

In the mathml evaluation test, we have some extra "functions"

    output local:expm1 units dimensionless
    define local:expm1 = MathML:exp(local:input) - 1 :: dimensionless
    output local:ln units dimensionless
    define local:ln = MathML:ln(local:input)
    output local:log units dimensionless
    define local:log = MathML:log(local:input)
    output local:log1p units dimensionless
    define local:log1p = 1 :: dimensionless + MathML:ln(local:input)

Note that these are not available as functions to the user, e.g. there is no expm1 that users can call

The test for log1p here uses log1p = 1 + log(p), which is different from numpy and C++, who both define a log1p as log1p = log(1 + p) (which makes it the inverse of exp1m)

Should we fix this?

@MichaelClerx
Copy link
Contributor Author

See also #139 #142

@jonc125
Copy link
Contributor

jonc125 commented Nov 18, 2020

Probably should, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants