Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-srgb does not convert vertex colors #59

Open
BartGunshot opened this issue Jun 29, 2021 · 1 comment
Open

--no-srgb does not convert vertex colors #59

BartGunshot opened this issue Jun 29, 2021 · 1 comment

Comments

@BartGunshot
Copy link

The --no-srgb flag should probably convert vertex colors to rgb as it does textures. This might need to be handled upstream in blendergltf.

@rdb
Copy link
Contributor

rdb commented Nov 3, 2022

For clarity…

Note that vertex colours are always linear, even when stored as bytes. panda3d-gltf just passes through the vertex colours unchanged. Also see KhronosGroup/glTF#1638. This is partially because GPU drivers do not actually support sRGB vertex colours, unfortunately.

What you're asking for is a feature to convert them to sRGB encoding when using --no-srgb. It seems potentially useful, but there should be an opt-out for people who use vertex colours to store non-colour data.

It might also be interesting to consider something upstream in Panda3D for this, to automatically convert vertex colours in the munger as needed, but this would need to be coordinated with other colour space work in Panda3D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants