Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocks.json isn't updated with the flattened keys #70

Open
NSPC911 opened this issue Aug 24, 2024 · 4 comments
Open

blocks.json isn't updated with the flattened keys #70

NSPC911 opened this issue Aug 24, 2024 · 4 comments

Comments

@NSPC911
Copy link

NSPC911 commented Aug 24, 2024

blocks.json isn't updated with the flattened keys even though terrain_texture.json has been.

It is a really annoying thing to do as I can't find the diff and how to update my packs because the change in keys don't have a pattern.
The game files have already been updated with the new keys, so it shouldn't be hard to do so.

I would love to make a PR to fix it, but based on my experience, yeah it would be rejected lol

@NSPC911
Copy link
Author

NSPC911 commented Aug 24, 2024

@mammerla should be a simple fix imo, wouldn't mind if you do a force push to fix it

@NSPC911
Copy link
Author

NSPC911 commented Aug 24, 2024

Also needs to remove old keys like stone_slab_side unless you really want backwards compatibility (commit history exists)

@mammerla
Copy link
Collaborator

(Sorry about this, there is an issue with our doc generation that should be fixed in subsequent updates)

@NSPC911
Copy link
Author

NSPC911 commented Sep 17, 2024

From @mammerla
(Sorry about this, there is an issue with our doc generation that should be fixed in subsequent updates)

Hi, it still isnt fixed in 1.21.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants