Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to represent periodic systems in QCSchema? #86

Open
aizvorski opened this issue Jun 10, 2024 · 2 comments
Open

How to represent periodic systems in QCSchema? #86

aizvorski opened this issue Jun 10, 2024 · 2 comments

Comments

@aizvorski
Copy link

aizvorski commented Jun 10, 2024

Is there a way to represent periodic systems? I searched the documentation but couldn't find anything. If not, is there interest in adding this?

It seems the minimum is to add a key "box_vectors" with a value containing the three vectors (flattened into a single list if you prefer). The meaning would be the same as OpenMM's Topology.getPeriodicBoxVectors().

A more ambitious version of this feature would include all the same info that is in CIF files, which have ways to represent symmetrical sites inside a unit cell (as symmetry ops under _symmetry_equiv_pos_as_xyz) as well as the unit cell (typically as length_a, length_b, length_c, angle_alpha, angle_beta, angle_gamma - equivalent to box_vectors). Ideally (and for ease of conversion) it might be literally the same info as in CIF files, possibly except for converting the units.

@ghutchis
Copy link
Collaborator

If QCSchema is still alive, I'd suggest it should borrow what we did for Avogadro Chemical JSON https://github.com/OpenChemistry/chemicaljson/blob/60f8a37a160706960c3591a5a508609400ec9122/chemicaljson.py#L166

We prefer the cellVectors, and use a, b, c, alpha, beta, gamma if needed.

Unfortunately, in my experience, not all CIF files include symmetrical sites, which is why we use space group / Hall number information to help identify symmetrically equivalent sites.

But I'd certainly be happy to add these to https://github.com/OpenChemistry/chemicaljson

@loriab
Copy link
Collaborator

loriab commented Jun 10, 2024

Yes, there's avid interest in adding periodic spec in just the way you suggest. It's in the plans, but there's no timeframe, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants