Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Catastrophic backtracking of multiline comments in FNIS Animlist regex leading to engine freezes with certain mods. #251

Closed
2 tasks done
gradashy opened this issue Jul 20, 2024 · 36 comments · Fixed by #254
Labels
bug Something isn't working

Comments

@gradashy
Copy link

Check for duplicate issues

  • I have verified that there are no duplicate issues.

Version

v1.6.0 Alpha

Provide Instructions on Reproducing the Problem

When trying to run nothing happens, it stays locked in the start in the engine, Rollback to the older version v1.5.1, and works as normal.

Using Skyrim VR, I have .net 8 installed and working

Provide Relevant Files

it generates nothing

Provide Visual Proof (optional)

No response

Contributing To Development

@gradashy gradashy added the bug Something isn't working label Jul 20, 2024
@InvIMj
Copy link

InvIMj commented Jul 20, 2024

Not only VR. Also on regular version SE 1.5.97.0
Doesn't work. Clicking Launch, does nothing.
Installed .net 8 as instructed.

@L-W-C00
Copy link

L-W-C00 commented Jul 21, 2024

+1,click launch, output"Engine launched with configuration: Skyrim SE/AE",and nothing happend.

@qx12
Copy link

qx12 commented Jul 21, 2024

+1

@Monitor221hz
Copy link
Owner

Have you tried clearing past output? And could someone post a list of all the FNIS mods they're using? As that's that only component that had major changes this version.

@qx12
Copy link

qx12 commented Jul 21, 2024

I cleaned already and The latest version of the NET file is installed.Character have animation in game,but some special animation have no effect,example dance.Additionally,ZAZ mods always likes this.

@Monitor221hz
Copy link
Owner

Please update to the latest version and retest the engine.

@Monitor221hz
Copy link
Owner

Monitor221hz commented Jul 21, 2024

Character have animation in game,but some special animation have no effect,example dance.Additionally,ZAZ mods always likes this.

Is the dance animation an ofa type animation? Animations that only play on arms via FNIS animlist should be compatible now.

@mydoom13
Copy link

v1.6.1-alpha the same as in version 1.6.0 tells me "Engine launched with configuration: Skyrim SE/AE" instead of a list of registered animations. In the game itself, any sexlab animations do not start.

@InvIMj
Copy link

InvIMj commented Jul 21, 2024

v1.6.1-alpha the same as in version 1.6.0 tells me "Engine launched with configuration: Skyrim SE/AE" instead of a list of registered animations. In the game itself, any sexlab animations do not start.

Same.

@Monitor221hz
Copy link
Owner

v1.6.1-alpha the same as in version 1.6.0 tells me "Engine launched with configuration: Skyrim SE/AE" instead of a list of registered animations. In the game itself, any sexlab animations do not start.

It sends that when the engine has started running. Did you wait for it to finish?

@mydoom13
Copy link

It displays this message immediately after start. I didn't wait very long as it used to take 6-7 seconds. but I waited about 30-40 seconds for sure.

@Monitor221hz
Copy link
Owner

It displays this message immediately after start. I didn't wait very long as it used to take 6-7 seconds. but I waited about 30-40 seconds for sure.

Can you post the engine.log?

@Monitor221hz
Copy link
Owner

Alright, I found the issue. Catastrophic backtracking with the regex used to match animline. Should be fixed next version.

@mydoom13
Copy link

mydoom13 commented Jul 21, 2024

Engine.log
Here. but there is only one entry "INFO : Skyrim Patcher 1.6.1-alpha"
It seems to me that it doesn’t even start working after pressing the button Launch

@Monitor221hz Monitor221hz changed the title [Bug]: Update does nothing (v1.6) [Bug]: Catastrophic backtracking of multiline comments in FNIS Animlist regex leading to engine freezes with certain mods. Jul 21, 2024
@Monitor221hz
Copy link
Owner

Please test with this experimental build And let me know if the problem persists.

@Monitor221hz
Copy link
Owner

The issue was closed as the problem seems to be solved, but do let me know if the issue remains.

@mydoom13
Copy link

I pressed Launch, waited a minute and went for a walk with the dog. ) When I returned, the process was completed successfully. "Launch finished in 925.87 seconds"!! It’s not surprising that we didn’t wait until the end, deciding that it didn’t work. Previously it took 6 seconds)

@Monitor221hz
Copy link
Owner

I pressed Launch, waited a minute and went for a walk with the dog. ) When I returned, the process was completed successfully. "Launch finished in 925.87 seconds"!! It’s not surprising that we didn’t wait until the end, deciding that it didn’t work. Previously it took 6 seconds)

oh my god

@Monitor221hz
Copy link
Owner

this seems to be a separate issue; I've moved it into #255

@Monitor221hz
Copy link
Owner

@mydoom13 are you on a HDD or SSD?

@mydoom13
Copy link

@mydoom13 are you on a HDD or SSD?
ssd

@mydoom13
Copy link

mydoom13 commented Jul 21, 2024

I gave the latest version to a friend and his animations took 974 seconds to generate. he also has ssd
we have approximately the same set of mods in the game

@Monitor221hz
Copy link
Owner

@mydoom13 please send your Engine.log

@mydoom13
Copy link

Engine.log

@Monitor221hz
Copy link
Owner

@mydoom13 that's not the latest version; can you retest with v1.6.3-alpha and not v1.6.2-alpha, and then post the new engine.log?

@mydoom13
Copy link

mydoom13 commented Jul 21, 2024

@mydoom13 that's not the latest version; can you retest with v1.6.3-alpha and not v1.6.2-alpha, and then post the new engine.log?

oh sorry, I didn't see the update. I installed and launched. as long as he does his job. Apparently it's still not fast.

@mydoom13
Copy link

mydoom13 commented Jul 21, 2024

Engine.log
Here. 1.6.3 became faster. 225 seconds

@InvIMj
Copy link

InvIMj commented Jul 21, 2024

1.6.3 Works like a charm, with fast generation times.
Only thing I noticed, was Let Your Hair Down's animation, makes the character T-Pose for awhile.

@TOHgoat
Copy link

TOHgoat commented Jul 21, 2024

still not work for me,it generates nothing.

@mydoom13
Copy link

1.6.3 Works like a charm, with fast generation times. Only thing I noticed, was Let Your Hair Down's animation, makes the character T-Pose for awhile.

How many seconds does Pandora take you to work? I'm on my last launch "Launch finished in 223.13 seconds" In version 1.5.1 it took me 6 seconds with the same set of mods.

@mydoom13
Copy link

still not work for me,it generates nothing.

Are you waiting long enough? this may take up to 15 minutes.

@TOHgoat
Copy link

TOHgoat commented Jul 21, 2024

I promise I waited for more than 15 minutes, but it still didn't generate anything, the Engine.log is empty.

@InvIMj
Copy link

InvIMj commented Jul 21, 2024

1.6.3 Works like a charm, with fast generation times. Only thing I noticed, was Let Your Hair Down's animation, makes the character T-Pose for awhile.

How many seconds does Pandora take you to work? I'm on my last launch "Launch finished in 223.13 seconds" In version 1.5.1 it took me 6 seconds with the same set of mods.

About 5-6 secs*, give or take.
Pretty fast overall.

Edit: 14 secs

@mydoom13
Copy link

1.6.3 Works like a charm, with fast generation times. Only thing I noticed, was Let Your Hair Down's animation, makes the character T-Pose for awhile.

How many seconds does Pandora take you to work? I'm on my last launch "Launch finished in 223.13 seconds" In version 1.5.1 it took me 6 seconds with the same set of mods.

About 5-6 secs, give or take. Pretty fast overall.

oh, how many animations does it register with you? I have 64k animations.

@InvIMj
Copy link

InvIMj commented Jul 21, 2024

1.6.3 Works like a charm, with fast generation times. Only thing I noticed, was Let Your Hair Down's animation, makes the character T-Pose for awhile.

How many seconds does Pandora take you to work? I'm on my last launch "Launch finished in 223.13 seconds" In version 1.5.1 it took me 6 seconds with the same set of mods.

About 5-6 secs, give or take. Pretty fast overall.

oh, how many animations does it register with you? I have 64k animations.

1

Yeah, you have waaaaay more than me...

@MaskPlague
Copy link

For 1.5.1 generation time is 4.6 seconds with 37k animations. For 1.6.0, 1.6.1, 1.6.2, and 1.6.3, I haven't successfully run the engine once giving 20 minutes to each version and the Engine log is empty for each version. Eagerly awaiting optimization. ;-;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
9 participants