Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add "large log" notification #79

Closed
seanvree opened this issue Feb 9, 2018 · 4 comments
Closed

Feat: Add "large log" notification #79

seanvree opened this issue Feb 9, 2018 · 4 comments

Comments

@seanvree
Copy link
Member

seanvree commented Feb 9, 2018

Feat: Add "large log" notification when user's x log is over x size.

@rob1998
Copy link
Contributor

rob1998 commented Jun 4, 2018

Do we want this to be separate from #91 ?
or merge it in one of the following ways:
1:
setting to set filesize for automatic rolling of log y when it is size x
when log y has a filesize of >= x then:
a notification that log is being rolled + rol log action

2:
setting to set filesize for automatic rolling and notification of log y when it is size x
setting to toggle automatic rolling + a setting to toggle large log notification
when log y has a filesize of >= x then:
if (notifcation = enabled) {a notification that log is being rolled}
if (rolling = enabled) {rol log action}
This way users can do notification + roll, or only notification/roll, or nothing at all (but all at the same file size)

3:
basically 2, but then with 2 settings for filesizes, 1 for notification and 1 for rolling

4:
more ideas?

@seanvree
Copy link
Member Author

seanvree commented Jun 5, 2018

@rob1998 Yeah, my intent with this was just to simply make the "log files size" text yellow in the slider div if above X size, red above X size. This MAY not be needed since we now have the max line limit??

@rob1998
Copy link
Contributor

rob1998 commented Jun 6, 2018

Yeah I would say not needed any more

@seanvree
Copy link
Member Author

seanvree commented Jun 6, 2018

Closed. will add with #91

@seanvree seanvree closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants