Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Disable ligatures for >=? #274

Open
brettcannon opened this issue May 25, 2024 · 1 comment
Open

[Feature request]: Disable ligatures for >=? #274

brettcannon opened this issue May 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@brettcannon
Copy link

What feature are you proposing?

In the ReScript programming language, having a parameter that consists of the characters >=? can happen when you have a typed parameter that takes a type variant that is optional. You can see an example at https://rescript-lang.org/docs/manual/latest/function#signatures-and-type-annotations of the line (~color: color, ~radius: option<int>=?) => {.

The issue is if you have ligatures turned on and "ss10" set then >= looks odd next to the ?. And since ReScript has its own formatter which strips any whitespace between the = and ? there isn't a way to avoid it without turning off "ss10" or ligatures entirely. So if there's a way to disable ligatures when the pattern >=? is found then that would be great to avoid this character sequence clash.

@brettcannon brettcannon added the enhancement New feature or request label May 25, 2024
@okonet
Copy link

okonet commented May 25, 2024

That makes sense. We should take a look at it. BTW I'm a big fan of the ReScript and been co-organizing the first ever two conferences for it here in Vienna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants