Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public/assets is not in gitignore #155

Closed
gabiudrescu opened this issue Jun 29, 2020 · 3 comments
Closed

public/assets is not in gitignore #155

gabiudrescu opened this issue Jun 29, 2020 · 3 comments

Comments

@gabiudrescu
Copy link

Description
The folder public/assets is not in gitignore

Steps to reproduce
create a new project
run yarn build instead of yarn dev
git commit -m "first commit"

observe public/assets is being committed, although it shouldn't.

Possible Solution
add public/assets to gitignore

@gabiudrescu
Copy link
Author

this could be an issue of the monofony/skeleton or flex recipe, because Monofony/Monofony has the complete gitignore file.

@loic425
Copy link
Member

loic425 commented Jun 29, 2020

@gabiudrescu You're right, I've seen this issue already, but I forgot to open an issue. This is a recipe error on monofony/core-bundle.

@loic425
Copy link
Member

loic425 commented Oct 29, 2020

It's fixed now, thanks @gabiudrescu 🎉

@loic425 loic425 closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants