fix: isLoading check for array responses #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ErnoW
pushed a commit
that referenced
this pull request
Feb 9, 2022
## [1.3.1](v1.3.0...v1.3.1) (2022-02-09) ### Bug Fixes * isLoading check for array responses ([#200](#200)) ([b0d8e7c](b0d8e7c))
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: "Pull request"
about: A new pull request
New Pull Request
Checklist
Issue Description
Related issue: #193
Solution Description
isLoading was checking for null AND empty array, which cannot happen. This should be an or expression.
Also split the check up for better readabiliy