Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in RaribleNetwork type #201

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

digiorgiu
Copy link
Contributor


name: "Pull request to fix a typo in RaribleNetwork type"
about: just a simple typo fix

New Pull Request

Checklist

  • [ x] I am not disclosing a vulnerability.
  • [ x] My code is conform the code style
  • [ x] I have made corresponding changes to the documentation
  • [ x] I have updated Typescript definitions when needed

Issue Description

There is typo in RaribleNetwork type definition -> 'rinkiby'

Related issue: #FILL_THIS_OUT

Solution Description

Correct from 'rinkiby' -> 'rinkeby'. So ts will suggest the right value and the autocomplete will not introduce error in useRarible hook.

@ErnoW ErnoW merged commit 0d7c608 into MoralisWeb3:main Mar 21, 2022
ErnoW pushed a commit that referenced this pull request Mar 21, 2022
## [1.3.4](v1.3.3...v1.3.4) (2022-03-21)

### Bug Fixes

* typo in RaribleNetwork type ([#201](#201)) ([0d7c608](0d7c608))
@ErnoW
Copy link
Member

ErnoW commented Mar 21, 2022

🎉 This PR is included in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ErnoW ErnoW added the released label Mar 21, 2022
@digiorgiu digiorgiu deleted the fixing-typo-userarible branch March 21, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants