Sharing iP code quality feedback [for @Morninggloryyy]

[soc-se-bot-red]

@Morninggloryyy We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Naming boolean variables/methods

No easy-to-detect issues 👍

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

No easy-to-detect issues 👍

Aspect: Recent Git Commit Message

possible problems in commit 987743c:

Added DukeException class (not coleted yet). Added delete method.

• Not in imperative mood (?)
• Subject line should not end with a period

possible problems in commit 1bbe6bf:

Slightly modified previous methods (changed a bit on printing formatting). Used the input/output redirection technique to semi-automate the testing of Damon.

• Longer than 72 characters
• Subject line should not end with a period

possible problems in commit c2eaa40:

modified previous methods, and added support for tracking three types of tasks (ToDos, Events, Deadlines)

• Not in imperative mood (?)
• Longer than 72 characters

Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).

Aspect: Binary files in repo

No easy-to-detect issues 👍

---

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.