Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate methods on QueryResults. add new ones #1270

Closed
evanchooly opened this issue Oct 11, 2018 · 0 comments
Closed

Deprecate methods on QueryResults. add new ones #1270

evanchooly opened this issue Oct 11, 2018 · 0 comments
Milestone

Comments

@evanchooly
Copy link
Member

Deprecate:

  1. asKeyList(*)
  2. asList(*)
  3. fetch(*)
  4. fetchEmptyEntities(*)
  5. fetchKeys(*)
  6. get(*)
  7. getKey(*)

Add:

  1. find(*)
  2. keys(*)

The new methods will return a MongoCursor as defined in the Java driver. The deprecated methods will have notations use find()/keys() as appropriate. There is a fair bit of ambiguity as to which method (fetch() vs asList()) to call. This change removes the ambiguity as there is only one method to call. This change also serves to simplify the API through the use of the driver options that can be passed in to the find() and keys() methods. This should reduce API fatigue/confusion for users and simplify maintenance in the long run.

@evanchooly evanchooly added this to the 1.4.0 milestone Oct 11, 2018
@evanchooly evanchooly changed the title Deprecate methods on Query. add new ones Deprecate methods on QueryResults. add new ones Oct 11, 2018
@evanchooly evanchooly modified the milestones: 1.4.0, 1.5.0 Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant