Prevent exception with browser autocompletion #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got an exception with "Google smart lock" in chrome. In single page application, if there is hidden login page where chrome automatically fills user's data. Then keyboard is shown because of autocompletion and we get an exception in $keyboard.caret() function "Cannot read length of null". With this changes keyboard is still opened but at least there is no exception.
|
Hi @vkurlyan! Thanks for the PR! I'm not sure when I'll be ready for the next release. I need some time to work on a few open issues, but if it takes longer than a week, I'll push a new release. |
|
@Mottie Thank you. |
|
v1.28.0 is now available. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an exception with "Google smart lock" in chrome. In single page application, if there is hidden login page where chrome automatically fills user's data. Then keyboard is shown because of autocompletion and we get an exception in $keyboard.caret() function "Cannot read length of null".
With this change, the keyboard is still opened for the hidden field but at least there is no exception.
To prevent opening of the keyboard developers should avoid hidden fields which could be autocompleted.