Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 not supported #21

Open
legovadim opened this issue Jan 4, 2019 · 6 comments
Open

IE11 not supported #21

legovadim opened this issue Jan 4, 2019 · 6 comments
Labels

Comments

@legovadim
Copy link

image

SCRIPT1002: Syntax error

@Mottie
Copy link
Owner

Mottie commented Jan 8, 2019

Hi @legovadim!

Thanks for letting me know! When I get some time, I'll get this fixed.

@Mottie Mottie added the bug label Jan 8, 2019
@obtdap
Copy link

obtdap commented Jan 28, 2019

Ok I found the problem. Assign of default value of a paramaeter of a function is not supported by IE11: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters

Simply change the following:
function processMask(mask = "#.##") {...

by
function processMask(mask) {
if (mask == null) { mask = "#.##"; }
...
}

I hope it'll works and please, make the change quickly (plzzzz!!!!) because my app don't work any more in IE11... Many thanks !!

@Mottie
Copy link
Owner

Mottie commented Jan 29, 2019

Sorry for the long delay.... v2.0.8 is now available. I added babel to the rollup config, but I didn't get a chance to test the resulting file: format.es5.js. Please let me know if you encounter any issues.

@obtdap
Copy link

obtdap commented Jan 29, 2019

Sorry for the long delay.... v2.0.8 is now available. I added babel to the rollup config, but I didn't get a chance to test the resulting file: format.es5.js. Please let me know if you encounter any issues.

Perfect ! I tried with the es5 and it works perfectly !
Many many thanks, I love your library :)

For me you can close the bug.

@Eflet
Copy link

Eflet commented Mar 21, 2019

HI , I use the latest version v2.0.8, still not work in IE11, throw SCRIPT1002

@Mottie
Copy link
Owner

Mottie commented Mar 21, 2019

Please make sure you're using format.es5.js... if you're using require, try this:

var format = require("./node_modules/number-format.js/lib/format.es5");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants