Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showAllRows sets p.size to p.totalPages, should be p.totalRows #1529

Closed
a-mair opened this issue Mar 19, 2018 · 3 comments
Closed

showAllRows sets p.size to p.totalPages, should be p.totalRows #1529

a-mair opened this issue Mar 19, 2018 · 3 comments
Labels
Bug Pager Widget

Comments

@a-mair
Copy link
Contributor

a-mair commented Mar 19, 2018 •
edited
Loading

Hi,

in widget-pager.js showAllRows sets p.size to p.totalPages but my guess is that it should be set to p.totalRows. Using v2.30.0.

Best regards,
Andreas
@Mottie
Copy link
Owner

Mottie commented Mar 19, 2018

Hi @a-mair!

LOL, thanks for letting me know! It's only been broken for a year (ref)!

@Mottie Mottie closed this as completed in 4f9cf81 Mar 19, 2018
@a-mair
Copy link
Contributor Author

a-mair commented Mar 19, 2018

Hi @Mottie,

thanks for fixing! You might consider removing "console.log(p.totalRows, p.totalPages);" again.

@Mottie
Copy link
Owner

Mottie commented Mar 19, 2018

LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Pager Widget
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mottie @a-mair