Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter-false no longer working on multiple row header #1550

Closed
mtgtnt opened this issue May 28, 2018 · 5 comments
Closed

sorter-false no longer working on multiple row header #1550

mtgtnt opened this issue May 28, 2018 · 5 comments
Labels

Comments

@mtgtnt
Copy link

mtgtnt commented May 28, 2018

https://stackoverflow.com/questions/16823951/tablesorter-with-two-header-rows

You can see even the jsfiddle is no longer working.

@Mottie
Copy link
Owner

Mottie commented May 28, 2018

Hi @mtgtnt!

Actually it is working as expected. The top 3 cells have sorting disabled, but the second row has not been disabled. If you wish to disable sorting completely, then add sorter-false to all thead cells.

@mtgtnt
Copy link
Author

mtgtnt commented May 28, 2018

If you click on the "January / February / March" cells, it shouldnt sort, but it does.

@Mottie
Copy link
Owner

Mottie commented May 28, 2018

Oh weird... I thought I fixed that a few weeks ago in ce0405b... I'll take another look. Thanks!

@mtgtnt
Copy link
Author

mtgtnt commented May 28, 2018

I had updated files on the server about a month ago and it took till now to troubleshoot what users were telling me so I went looking and found that jsfiddle and confirmed what I was seeing locally. It's not a big issue, just trying to keep PEBKAC's from clicking where they shouldn't and then complaining that it did something unexpected. I wanted to let you know about it. :)

@Mottie
Copy link
Owner

Mottie commented May 28, 2018

Hehe thanks... I found the problem. It's because of some minor changes to determine which column is being sorted when there is a colspan - see #1524.

@Mottie Mottie closed this as completed in 213747f May 28, 2018
@Mottie Mottie added the Bug label May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants